feat: 🎸 add create pool message #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelysn
reviewed
May 17, 2023
| repeated cosmos.base.v1beta1.Coin initialDeposit = 3 [(gogoproto.nullable) = false]; | ||
| uint64 swapFee = 4; | ||
| uint64 exitFee = 5; |
There was a problem hiding this comment.
Are we using uint64 value instead of sdk.Dec?
There was a problem hiding this comment.
those are percentage values so 0 to 100
There was a problem hiding this comment.
I think most of the pool's swap fees are in decimal and also it will need to describe 0.25% as well. Probably nice to upgrade to sdk.Dec later time.
jelysn
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.