-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portfolio keys migration and redundant data deletion #772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 42.38% 42.28% -0.10%
==========================================
Files 628 628
Lines 20500 20537 +37
==========================================
- Hits 8688 8685 -3
- Misses 10802 10840 +38
- Partials 1010 1012 +2 |
…003/portfolioKeys
// Remove last 100 values at each block | ||
k.RemovePortfolioLast(ctx, deleteDate.String(), 100) | ||
k.RemovePortfolioLast(ctx, deleteDate, 100) | ||
// migration does not delete all older entries as we don't know whats last date is there, deleting from past 105 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can put this logic in migration. will that not work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older entries might take a lot of time to finish deleting leading to workflow failure. So deleting in abci.
…003/portfolioKeys
No description provided.