Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate panic caused by must acc address in abci #750

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

cosmic-vagabond
Copy link
Contributor

Description

What has Changed?

Mitigate Panic error in leveragelp/ABCI caused by must acc account function


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Deployment Notes

Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.

Screenshots and Videos

Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 7.47%. Comparing base (85297a1) to head (9e38fc4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
x/masterchef/keeper/abci.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage    7.47%    7.47%   -0.01%     
==========================================
  Files         745      745              
  Lines      119599   119602       +3     
==========================================
  Hits         8940     8940              
- Misses     109608   109610       +2     
- Partials     1051     1052       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmic-vagabond cosmic-vagabond merged commit b15c656 into main Aug 29, 2024
20 of 21 checks passed
@cosmic-vagabond cosmic-vagabond deleted the fix/mitigate-must-acc-address-panic branch August 29, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants