Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/leveragelp hooks #748

Merged
merged 15 commits into from
Aug 29, 2024
Merged

Feat/leveragelp hooks #748

merged 15 commits into from
Aug 29, 2024

Conversation

cryptokage1996
Copy link
Contributor

@cryptokage1996 cryptokage1996 commented Aug 23, 2024

Description

Closes:

What has Changed?

  • Added Hooks for leveragelp
  • Added updated_leverage in get-positions-for-address query

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 40.40404% with 59 lines in your changes missing coverage. Please review.

Project coverage is 42.42%. Comparing base (cfc04bd) to head (250dc6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   42.44%   42.42%   -0.03%     
==========================================
  Files         626      628       +2     
  Lines       20387    20457      +70     
==========================================
+ Hits         8654     8679      +25     
- Misses      10736    10772      +36     
- Partials      997     1006       +9     
Components Coverage Δ
leveragelp_transactions 82.84% <50.00%> (-2.06%) ⬇️
leveragelp_lifecycle 88.29% <ø> (ø)
leveragelp_keeper 48.35% <60.00%> (+0.67%) ⬆️
leveragelp_queries 19.28% <41.66%> (+1.47%) ⬆️
accountedpool_transactions 100.00% <ø> (ø)
accountedpool_lifecycle ∅ <ø> (∅)
accountedpool_queries 68.42% <ø> (ø)
amm_transactions 57.93% <ø> (ø)
amm_lifecycle 79.16% <ø> (ø)
amm_keeper 61.13% <ø> (ø)
amm_queries 29.94% <ø> (ø)
assetprofile_transactions 78.82% <ø> (ø)
assetprofile_lifecycle ∅ <ø> (∅)
assetprofile_keeper 83.33% <ø> (ø)
assetprofile_queries 47.41% <ø> (ø)
burner_transactions 0.00% <ø> (ø)
burner_lifecycle ∅ <ø> (∅)
burner_keeper 100.00% <ø> (ø)
burner_queries 63.54% <ø> (ø)
clock_transactions 30.00% <ø> (ø)
clock_lifecycle ∅ <ø> (∅)
clock_keeper 76.92% <ø> (ø)
clock_queries ∅ <ø> (∅)
commitment_transactions 48.95% <ø> (ø)
commitment_lifecycle ∅ <ø> (∅)
commitment_keeper 19.60% <ø> (ø)
commitment_queries 9.33% <ø> (ø)
epochs_transactions ∅ <ø> (∅)
epochs_lifecycle 100.00% <ø> (ø)
epochs_keeper 81.81% <ø> (ø)
epochs_queries 85.71% <ø> (ø)
estaking_transactions 48.64% <ø> (ø)
estaking_lifecycle 71.23% <ø> (ø)
estaking_keeper 63.05% <ø> (ø)
estaking_queries 55.31% <ø> (ø)
incentive_transactions 0.00% <ø> (ø)
incentive_lifecycle ∅ <ø> (∅)
incentive_keeper 0.00% <ø> (ø)
incentive_queries ∅ <ø> (∅)
masterchef_transactions 63.63% <ø> (ø)
masterchef_lifecycle 73.75% <ø> (ø)
masterchef_keeper 89.47% <ø> (ø)
masterchef_queries 45.97% <ø> (ø)
oracle_transactions 30.00% <ø> (ø)
oracle_lifecycle 0.00% <ø> (ø)
oracle_keeper 63.88% <ø> (ø)
oracle_queries 34.95% <ø> (ø)
parameter_transactions 15.11% <ø> (ø)
parameter_lifecycle ∅ <ø> (∅)
parameter_keeper 75.00% <ø> (ø)
parameter_queries 60.00% <ø> (ø)
stablestake_transactions 73.91% <ø> (ø)
stablestake_lifecycle 75.00% <ø> (ø)
stablestake_keeper 71.42% <ø> (ø)
stablestake_queries 13.04% <ø> (ø)
tier_transactions 28.57% <ø> (ø)
tier_lifecycle 100.00% <ø> (ø)
tier_keeper 90.47% <ø> (ø)
tier_queries 22.50% <ø> (ø)
tokenomics_transactions 72.32% <ø> (ø)
tokenomics_lifecycle ∅ <ø> (∅)
tokenomics_keeper 83.33% <ø> (ø)
tokenomics_queries 70.96% <ø> (ø)
transferhook_transactions ∅ <ø> (∅)
transferhook_lifecycle ∅ <ø> (∅)
transferhook_keeper 100.00% <ø> (ø)
transferhook_queries 60.00% <ø> (ø)

@cryptokage1996 cryptokage1996 marked this pull request as ready for review August 24, 2024 15:33
Copy link
Contributor

@amityadav0 amityadav0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for hooks and updated query, Also we need setHooks in app.go

x/amm/types/expected_keepers.go Outdated Show resolved Hide resolved
x/leveragelp/keeper/keeper.go Outdated Show resolved Hide resolved
@amityadav0
Copy link
Contributor

thanks, could you please add ss of localnet testing ? are hooks working as expected with snapshot ?

@cryptokage1996
Copy link
Contributor Author

thanks, could you please add ss of localnet testing ? are hooks working as expected with snapshot ?

before firing transaction on chain

elysd q tier list-portfolio
pagination:
  next_key: null
  total: "0"
portfolio:
- creator: elys1dd34v384hdfqgajkg0jzp0y5k6qlvhltt76qd5
  portfolio: "5708565228.910097561786000000"
- creator: elys1g3qnq7apxv964cqj0hza0pnwsw3q920lcc5lyg
  portfolio: "0.000000000000000000"

after firing transaction:
elysd tx leveragelp open 5 ibc/2180E84E20F5679FCC760D8C165B60F42065DEF7F46A72B447CFF1B7DC6C0A65 10000 2 10 --from=v --keyring-backend=test --yes --gas=6000000

elysd q tier list-portfolio
pagination:
  next_key: null
  total: "0"
portfolio:
- creator: elys1dd34v384hdfqgajkg0jzp0y5k6qlvhltt76qd5
  portfolio: "5708565228.910097561786000000"
- creator: elys1g3qnq7apxv964cqj0hza0pnwsw3q920lcc5lyg
  portfolio: "0.000000000000000000"
- creator: elys1s55wjwura8q5ra49etfhpcak5zprwrnm5c8xxj
  portfolio: "99.999822340238875279"
- creator: elys1xgt7sjcysfypucecrpt8r7ffe72pfp6ryhu9dq
  portfolio: "0.049822340238875279"

@cosmic-vagabond cosmic-vagabond merged commit 92ad322 into main Aug 29, 2024
68 of 71 checks passed
@cosmic-vagabond cosmic-vagabond deleted the feat/leveragelp-hooks branch August 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants