Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: epochs infos missing start time #438

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

cosmic-vagabond
Copy link
Contributor

Description

What has Changed?

  • init time value to current start time and start time fields of newly added epoch infos

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Deployment Notes

Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.

Screenshots and Videos

Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

@cosmic-vagabond
Copy link
Contributor Author

successfully upgraded in localnet and tested:

$ elysd q epochs epoch-infos
epochs:
- current_epoch: "2054374"
  current_epoch_start_height: "6739296"
  current_epoch_start_time: "2024-04-01T10:35:49Z"
  duration: "15000000000"
  epoch_counting_started: true
  identifier: band_epoch
  start_time: "2023-04-10T18:42:34Z"
- current_epoch: "357"
  current_epoch_start_height: "6739275"
  current_epoch_start_time: "2024-03-31T18:42:34Z"
  duration: "86400000000000"
  epoch_counting_started: true
  identifier: day
  start_time: "2023-04-10T18:42:34Z"
- current_epoch: "1"
  current_epoch_start_height: "6739289"
  current_epoch_start_time: "2024-04-01T16:17:21.723045Z"
  duration: "14400000000000"
  epoch_counting_started: true
  identifier: fourhours
  start_time: "2024-04-01T16:17:21.723045Z"
- current_epoch: "1"
  current_epoch_start_height: "6739289"
  current_epoch_start_time: "2024-04-01T16:17:21.723047Z"
  duration: "1800000000000"
  epoch_counting_started: true
  identifier: halfhour
  start_time: "2024-04-01T16:17:21.723047Z"
- current_epoch: "8566"
  current_epoch_start_height: "6739280"
  current_epoch_start_time: "2024-04-01T15:42:34Z"
  duration: "3600000000000"
  epoch_counting_started: true
  identifier: hour
  start_time: "2023-04-10T18:42:34Z"
- current_epoch: "1"
  current_epoch_start_height: "6739289"
  current_epoch_start_time: "2024-04-01T16:17:21.72304Z"
  duration: "21600000000000"
  epoch_counting_started: true
  identifier: sixhours
  start_time: "2024-04-01T16:17:21.72304Z"
- current_epoch: "3081550"
  current_epoch_start_height: "6739296"
  current_epoch_start_time: "2024-04-01T10:34:04Z"
  duration: "10000000000"
  epoch_counting_started: true
  identifier: tenseconds
  start_time: "2023-04-10T18:42:34Z"
- current_epoch: "1"
  current_epoch_start_height: "6739289"
  current_epoch_start_time: "2024-04-01T16:17:21.723036Z"
  duration: "43200000000000"
  epoch_counting_started: true
  identifier: twelvehours
  start_time: "2024-04-01T16:17:21.723036Z"
- current_epoch: "1"
  current_epoch_start_height: "6739289"
  current_epoch_start_time: "2024-04-01T16:17:21.723046Z"
  duration: "7200000000000"
  epoch_counting_started: true
  identifier: twohours
  start_time: "2024-04-01T16:17:21.723046Z"
- current_epoch: "51"
  current_epoch_start_height: "6739275"
  current_epoch_start_time: "2024-03-25T18:42:34Z"
  duration: "604800000000000"
  epoch_counting_started: true
  identifier: week
  start_time: "2023-04-10T18:42:34Z"
pagination:
  total: "10"

@cosmic-vagabond cosmic-vagabond merged commit acea93f into main Apr 1, 2024
1 check passed
@cosmic-vagabond cosmic-vagabond deleted the fix/epoch-infos branch April 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant