Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join/exit pool unit test #132

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Join/exit pool unit test #132

merged 4 commits into from
Jun 27, 2023

Conversation

jelysn
Copy link
Contributor

@jelysn jelysn commented Jun 26, 2023

No description provided.

…peration

- Remove swapFee on JoinPool functions
- Add missing function for IncreaseLiquidity call on oracle pool join
- Add join pool unit test
@jelysn jelysn marked this pull request as draft June 26, 2023 02:56
- Resolve address conversion from pool address on applyJoinPoolStateChange & applyExitPoolStateChange
- Resolve auto-withdraw amount from commitment module for lp tokens
…after swap by fixing Quo amount on out amount calculation

- Resolve cases for all oracle pool tests
@jelysn jelysn marked this pull request as ready for review June 27, 2023 01:07
Copy link
Contributor

@cosmic-vagabond cosmic-vagabond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmic-vagabond cosmic-vagabond merged commit b8ca2d2 into main Jun 27, 2023
@cosmic-vagabond cosmic-vagabond deleted the unit_test_join_exit_pool branch June 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants