Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial LP token price to be one & add unit test for create pool #131

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

jelysn
Copy link
Contributor

@jelysn jelysn commented Jun 23, 2023

No description provided.

- Add unit test for MsgServerCreatePool
- Add utility to setup price of few assets on keeper test
@@ -15,6 +15,15 @@ import (
// - Records total liquidity increase
// - Calls the AfterPoolCreated hook
func (k Keeper) InitializePool(ctx sdk.Context, pool *types.Pool, sender sdk.AccAddress) (err error) {
tvl, err := pool.TVL(ctx, k.oracleKeeper)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one solved the issue that the lp tokens were not balanced?

Copy link
Contributor

@kenta-elys kenta-elys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

@cosmic-vagabond cosmic-vagabond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmic-vagabond cosmic-vagabond merged commit 8b599d6 into main Jun 23, 2023
@cosmic-vagabond cosmic-vagabond deleted the feat/create_pool_unit_test branch June 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants