Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap edge case tests & fix panics on swap #128

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

jelysn
Copy link
Contributor

@jelysn jelysn commented Jun 22, 2023

  • Handle panic case on RouteExactAmountIn && RouteExactAmountOut on multihop routed for zero division
  • Fix zero division case on createElysMultihopExpectedSwapOuts
  • Update MsgServerSwapExactAmountIn test to handle multihop case and invalid route case
  • Update MsgServerSwapExactAmountOut test to handle multihop case and invalid route case

…ultihop routed for zero division

- Fix zero division case on createElysMultihopExpectedSwapOuts
- Update MsgServerSwapExactAmountIn test to handle multihop case and invalid route case
- Update MsgServerSwapExactAmountOut test to handle multihop case and invalid route case
Copy link
Contributor

@cosmic-vagabond cosmic-vagabond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmic-vagabond cosmic-vagabond merged commit f564e18 into main Jun 22, 2023
@cosmic-vagabond cosmic-vagabond deleted the feat/swap_edge_test_cases_and_fix branch June 22, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants