-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script editor debugger - experimental #2087
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Fix enable button bug Track current widget
Update kernel name on init
13b7ffe
to
9c6e8d9
Compare
Handle default kernel init Handle exception in startSession Test update
Agreed, the same behavior happens in notebooks so we can implement the enhancement upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor edits for consistency and relevancy
comment failing tests
@ptitzler thx for reviewing! Comments are addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool! I just have a few documentation NITs below
Comment pipeline tests to be investigated
@kiersten-stokes thanks for the feedback! |
Fix integration tests calling dismissAssistant
ef5ca83
to
525247e
Compare
@akchinSTC thank you for the suggestions, doc updates addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting!
4937240
to
525247e
Compare
Closes #975 - Integrate Script Editor with JupyterLab debugger
What changes were proposed in this pull request?
Know issues / Follow ups:
How was this pull request tested?
No new test added for the experimental feature yet - debugger feature tested manually, tests to follow.
Existing script editor tests updated.
Developer's Certificate of Origin 1.1