Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2108 Need shouldFilterItem support for oneofselect control #2109

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

srikant-ch5
Copy link
Contributor

Fixes: #2108

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@srikant-ch5 srikant-ch5 self-assigned this Aug 19, 2024
@@ -522,10 +522,29 @@ describe("oneofselect with custom value allowed works correctly", () => {
let dropdownWrapper = wrapper.find("div[data-id='properties-oneofselect-custom']");
const dropdownInput = dropdownWrapper.find("input");
dropdownInput.simulate("click");
// Enter 'e' in input to check [one, three] are filtered using shouldFilterItem
dropdownInput.simulate("change", { target: { value: "e" } });
Copy link
Contributor Author

@srikant-ch5 srikant-ch5 Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @caritaou I have added this line because after adding shouldFilterItem dropdownList is having 0 items, is this fine ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srikant-ch5, in this case, shouldn't the list show all options since nothing was entered? I would expect this test to behave like this example:
enum filter
If the test is wrong, can you help fix it using this example? This test is to verify the enumFilter works correctly

Copy link
Contributor Author

@srikant-ch5 srikant-ch5 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @caritaou yes after adding shouldFilterItem in ComboBox it is working as expected please refer below recording which is same as recording attached above.

Screen.Recording.2024-08-21.at.9.02.30.PM.mov

As it is filtered using inputValue in newly added function I have addedinput.target.value="" condition in test case.

@caritaou caritaou merged commit d73fff1 into elyra-ai:main Aug 21, 2024
3 checks passed
@srikant-ch5 srikant-ch5 deleted the 3853_oneofselect_filter branch December 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need shouldFilterItem support for oneofselect control
2 participants