test: use snapshot

[marcalexiei]

Part of #141

---

Unit tests updates

Snapshots

Snapshots are used whenever is possible.

Warning

It was not possible to use them in all tests.

Detailed explanation

watchlist

Can't use snapshot since is comparing rollup properties with file system files.
However I was able to simplify the logic (I created a separate commit).

output

Using snapshot here is not feasible due to rollup:
It looks like that, randomly, plugin transform is called first on actual_b and then on actual_a instead of calling transform on actual_a and then on actual_b.

So instead of having:

body{color:red}body{color:green}

you end up having

body{color:green}body{color:red}

But only some times.

This looks like a rollup bug:

• Module execution order can be incorrect rollup/rollup#3888

Right now on main branch should support output as function sometimes fails for the exact same reason.
Also on other tests involving output, assertions are written using indexOf !== -1 logic.
I assume it's because of this bug.

E.g.:

rollup-plugin-sass/test/index.test.ts

Lines 265 to 268 in 0425739

	.then((rslt) => {
	t.not(squash(rslt.toString()).indexOf(expectA), -1);
	t.not(squash(rslt.toString()).indexOf(expectB), -1);
	});

Right now there isn't much we can do.
I'm going to add a code comment on options.output.test.ts referencing this PR

insertStyle.test.ts – replace jsdom with happy-dom

Since the test are quite simple I opted out to switch jsdom to happy-dom (less dependencies and faster)

Additional changes

• All unit test dependencies have been updated:
  • ava
  • @ava/typescript
  • nyc
  • sinon
• Added missing @types for
  • sinon
  • icss-utils

[marcalexiei]

All review comments of #143 have been applied in this PR

[elycruz]

Left a couple of comments - Review of test/index.test.ts still pending.

[elycruz]

throw test seems un-required here - reasoning?

[marcalexiei]

I can only guess the reason... this assertion is already present on the main branch

rollup-plugin-sass/test/style.test.ts

Line 31 in 0425739

t.throws(() => !window);

the tests are probably executed in strict mode so an error occurs if you access a variable that doesn't exists

[elycruz]

Do we need to track these *.snap files?

[marcalexiei]

https://github.com/avajs/ava/blob/main/docs/04-snapshot-testing.md

Say you have ~/project/test/main.js which contains snapshot assertions. AVA will create two files:

• ~/project/test/snapshots/main.js.snap
• ~/project/test/snapshots/main.js.md

The first file contains the actual snapshot and is required for future comparisons.
The second file contains your snapshot report. It's regenerated when you update your snapshots.
If you commit it to source control you can diff it to see the changes to your snapshot.

[marcalexiei]

@elycruz yesterday you made changes to test on main via #153 leading to conflicts with the work I done here.
Snapshot test update PRs has been opened for nearly 2 months (#143) so could you please complete the review?
If you changed your mind feel free to close this.

[elycruz]

@marcalexiei Hey, right - apologies about that - have been uber swamped lately -
Not a problem - I'm merging it into the 'dev' branch (will make some annotations) and will add you to the subsequent PR -
I'll correct/make-small-updates for annotations I'm making and then after you review those changes we can merge it.