Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Installation #6

Closed
hayesall opened this issue Jul 13, 2021 · 5 comments
Closed

Documentation: Installation #6

hayesall opened this issue Jul 13, 2021 · 5 comments

Comments

@hayesall
Copy link
Contributor

Installation instructions should be included in the main README and associated documentation.

Recommendation:

@rweigel
Copy link
Collaborator

rweigel commented Jul 13, 2021

It is standard to include dependencies in setup.py. Without it, the user would need to search for all of the import statements to determine dependencies.

@rweigel
Copy link
Collaborator

rweigel commented Jul 13, 2021

Test by creating a virtual environment and executing pip install nnde followed by execution of a test or demo. I thought that I did this when testing but clearly I missed it.

@rweigel
Copy link
Collaborator

rweigel commented Jul 13, 2021

I suggest adding the following section to README.md

Installation

To install the library, use

git clone https://github.com/elwinter/nnde.git
cd nnde; pip install -e .

or

pip install nnde

The demos are stored in a separate repository. To use them, execute

git clone https://github.com/elwinter/nnde_demos
cd nnde_demos
python lagaris01_demo.py
python nnpde2diff_demo.py

@hayesall
Copy link
Contributor Author

Good recommendation @rweigel. #4 also includes the point for adding all requirements under install_requires in setup.py.

Repository owner deleted a comment from elwinter Jul 17, 2021
@elwinter
Copy link
Owner

Instructions for installing from PyPI using pip, and by cloning the GitHub repository, have been added to the top-level README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants