Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation: Required packages in setup.py #4

Closed
hayesall opened this issue Jul 13, 2021 · 1 comment
Closed

Installation: Required packages in setup.py #4

hayesall opened this issue Jul 13, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hayesall
Copy link
Contributor

Prerequisite packages are missing in setup.py, leading to errors such as the following:

>>> from nnde.neuralnetwork.nnode1ivp import NNODE1IVPv
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hayesall/Review/nnde/nnde/neuralnetwork/nnode1ivp.py", line 44, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

Recommendations:


Reproduce with:

# Clone repository
git clone [email protected]:elwinter/nnde.git
cd nnde

# Setup a fresh conda environment
conda create -n nnde python=3.7
conda activate nnde
pip install -e .

# Reproduce error
python
>>> from nnde.neuralnetwork.nnode1ivp import NNODE1IVPv
@hayesall hayesall changed the title Required packages in setup.py Installation: Required packages in setup.py Jul 13, 2021
@elwinter elwinter self-assigned this Jul 31, 2021
@elwinter elwinter added the bug Something isn't working label Jul 31, 2021
@elwinter
Copy link
Owner

This has been addressed in the latest setup.py as follows:

install_requires=['matplotlib', 'numpy', 'scipy']

It was verified in a bare-bones conda environment created for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants