Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkflowInstance state before resuming #4573

Merged

Conversation

dakuchar
Copy link

This is needed to resolve concurrency problems, where another Engine Instance has changed the state of the resuming workflowinstance.

The state of the workflowinstance is updated after the lock on the workflowinstance has been acquired.

See discussion: #4546

This is needed to resolve concurrency problems, where another Engine Instance has changed the state of the resuming workflowinstance.
@dakuchar
Copy link
Author

@dotnet-policy-service agree company="MMI MUNICH MEDIA INTELLIGENCE GmbH"

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sfmskywalker sfmskywalker merged commit 8e4a79a into elsa-workflows:master Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants