Kill reactor properly

[rojepp]

Fixes #10, tested on OSX only.

[Krzysztof-Cieslak]

I'm not sure if it's enough - in Ionide we do something like that to kill processes on Windows https://github.com/ionide/ionide-vscode-fake/blob/master/src/fake.fs#L51-L55

[rojepp]

Thanks! A combination of the two worked.

[rojepp]

Probably reactor should also be killed when code exits?

[Krzysztof-Cieslak]

I think child processes are killed when node applications exists.

[rojepp]

Reactor process still lives on Windows after I quit code. I'll check OSX tomorrow.

[Krzysztof-Cieslak]

Looks like it's problem in VS Code indeed, microsoft/vscode-go#26

[rojepp]

We can just call a silent version stopReactor on process exit? I'll do that in a few hours.

[Krzysztof-Cieslak]

It was discussed in issue I've linked, looks like there are some problems with that.

[rojepp]

We could probably implement some hack to do it, but I'd prefer waiting for vscode support for deactivation. I'd say this PR is ready to merge.

[Krzysztof-Cieslak]

👍