Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make combine faster #72

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Make combine faster #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions src/Maybe/Extra.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,23 @@ If there are any `Nothing`s, the whole function fails and returns `Nothing`.

-}
combine : List (Maybe a) -> Maybe (List a)
combine =
List.foldr (map2 (::)) (Just [])
combine list =
combineHelp list []


combineHelp : List (Maybe a) -> List a -> Maybe (List a)
combineHelp list acc =
case list of
head :: tail ->
case head of
Just a ->
combineHelp tail (a :: acc)

Nothing ->
Nothing

[] ->
Just (List.reverse acc)


{-| Like [`combine`](#combine), but map a function over each element of the list first.
Expand Down