Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell.nix + GH Actions + concatMap function (proposal) βœ… #69

Closed
wants to merge 1 commit into from

Conversation

kutyel
Copy link
Contributor

@kutyel kutyel commented Nov 9, 2021

Hi again! πŸ‘‹πŸ»

I noticed this repo did not have any sort of CI so I wanted to propose this one (blatantly copied from https://github.com/turboMaCk/any-dict), it works pretty fast and I think the set up is very quick!

I also felt like proposing to contribute the concatMap function (was surprised to notice today that it is missing in the core module when I tried to use it), but feel free to discard that change if we only want to have a functioning CI pipeline as as result of this PR πŸ˜‰

@skyqrose skyqrose mentioned this pull request Nov 11, 2021
@skyqrose
Copy link
Collaborator

concatMap has the arguments in the same order as andThen : (a -> Maybe b) -> Maybe a -> Maybe b

Thanks for the CI proposal. That's something I'd been wanting to do, but hadn't really thought much about how to actually do it. I do like nix, and have been looking at finding ways to use it, but given the existing ecosystem around npm, which this repo is already bought into, I think npm will be a more maintainable tool to use for building in ci.

I've made #70, built off the core of this PR. Can you take a look at it and see if there's anything I've missed?

@kutyel
Copy link
Contributor Author

kutyel commented Nov 11, 2021

Right, closing this in favor of #70 πŸ˜‰

@kutyel kutyel closed this Nov 11, 2021
@kutyel kutyel deleted the add-ci-and-concatMap branch November 11, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants