Update mime type and docs #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellisonbg Care to review? |
ellisonbg
requested changes
Mar 11, 2017
altair/api.py
Outdated
| @@ -233,7 +233,10 @@ def configure_facet_scale(self, *args, **kwargs): | |||
| def _ipython_display_(self): | |||
| from IPython.display import display | |||
| spec = self.to_dict() | |||
| data = {'application/vnd.vegalite+json': spec} | |||
| data = { | |||
There was a problem hiding this comment.
Where is the sanitization being done? What if we use the VegaLite class here to do all of that?
gnestor
force-pushed
the
jupyterlab
branch
2 times, most recently
from
3459346
to
738f1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of vega#216