Skip to content
This repository has been archived by the owner on May 4, 2020. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
elliottsj committed May 29, 2019
1 parent 4ed124c commit 53660df
Show file tree
Hide file tree
Showing 5 changed files with 199 additions and 219 deletions.
12 changes: 5 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@

Reproduction of a bug with Rush + pnpm: https://github.com/Microsoft/web-build-tools/issues/1142

The bug is that **react-focus-lock@1.18.2** is installed, despite **[email protected]** being declared in [shrinkwrap.yaml](common/config/rush/shrinkwrap.yaml):
The bug is that **react-focus-lock@1.19.1** is installed, despite **[email protected]** being declared in [pnpm-lock.yaml](common/config/rush/pnpm-lock.yaml):

```shell
$ npm install --global @microsoft/rush
$ rush install
$ cat common/temp/node_modules/.registry.npmjs.org/react-focus-lock/1.18.2/[email protected]/node_modules/react-focus-lock/package.json
$ cat common/temp/node_modules/.registry.npmjs.org/react-focus-lock/1.19.1/node_modules/react-focus-lock/package.json
{
"name": "react-focus-lock",
"version": "1.18.2",
"version": "1.19.1",
"description": "It is a trap! (for a focus)",
...
```
**This bug seems not to occur when using pnpm without Rush**. I've copied `common/temp/package.json` and `common/config/rush/shrinkwrap.yaml` into a directory `pnpm-only/` and removed all references to "mypackage.tgz". Perform the install using just pnpm:
**This bug seems not to occur when using pnpm without Rush**. I've copied `common/temp/package.json` and `common/config/rush/pnpm-lock.yaml` into a directory `pnpm-only/` and removed all references to "mypackage.tgz". Perform the install using just pnpm:
```shell
$ cd pnpm-only/
$ npm install --global pnpm@2.25.6
$ npm install --global pnpm@3.4.1
$ pnpm install
$ cat node_modules/.registry.npmjs.org/react-focus-lock/1.17.7/node_modules/react-focus-lock/package.json
{
Expand All @@ -28,5 +28,3 @@ $ cat node_modules/.registry.npmjs.org/react-focus-lock/1.17.7/node_modules/reac
"description": "It is a trap! (for a focus)",
...
```
This may indicate that it's actually a pnpm bug related to `.tgz` dependencies?
Loading

0 comments on commit 53660df

Please sign in to comment.