This repository has been archived by the owner on May 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade to [email protected], [email protected]
- Loading branch information
Showing
5 changed files
with
199 additions
and
219 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,24 @@ | |
|
||
Reproduction of a bug with Rush + pnpm: https://github.com/Microsoft/web-build-tools/issues/1142 | ||
|
||
The bug is that **react-focus-lock@1.18.2** is installed, despite **[email protected]** being declared in [shrinkwrap.yaml](common/config/rush/shrinkwrap.yaml): | ||
The bug is that **react-focus-lock@1.19.1** is installed, despite **[email protected]** being declared in [pnpm-lock.yaml](common/config/rush/pnpm-lock.yaml): | ||
|
||
```shell | ||
$ npm install --global @microsoft/rush | ||
$ rush install | ||
$ cat common/temp/node_modules/.registry.npmjs.org/react-focus-lock/1.18.2/[email protected]/node_modules/react-focus-lock/package.json | ||
$ cat common/temp/node_modules/.registry.npmjs.org/react-focus-lock/1.19.1/node_modules/react-focus-lock/package.json | ||
{ | ||
"name": "react-focus-lock", | ||
"version": "1.18.2", | ||
"version": "1.19.1", | ||
"description": "It is a trap! (for a focus)", | ||
... | ||
``` | ||
**This bug seems not to occur when using pnpm without Rush**. I've copied `common/temp/package.json` and `common/config/rush/shrinkwrap.yaml` into a directory `pnpm-only/` and removed all references to "mypackage.tgz". Perform the install using just pnpm: | ||
**This bug seems not to occur when using pnpm without Rush**. I've copied `common/temp/package.json` and `common/config/rush/pnpm-lock.yaml` into a directory `pnpm-only/` and removed all references to "mypackage.tgz". Perform the install using just pnpm: | ||
```shell | ||
$ cd pnpm-only/ | ||
$ npm install --global pnpm@2.25.6 | ||
$ npm install --global pnpm@3.4.1 | ||
$ pnpm install | ||
$ cat node_modules/.registry.npmjs.org/react-focus-lock/1.17.7/node_modules/react-focus-lock/package.json | ||
{ | ||
|
@@ -28,5 +28,3 @@ $ cat node_modules/.registry.npmjs.org/react-focus-lock/1.17.7/node_modules/reac | |
"description": "It is a trap! (for a focus)", | ||
... | ||
``` | ||
This may indicate that it's actually a pnpm bug related to `.tgz` dependencies? |
Oops, something went wrong.