Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent OTP 24 compile-time warning #107

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Prevent OTP 24 compile-time warning #107

merged 1 commit into from
Jun 17, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Mar 23, 2021 •
edited
Loading

(parse_trans required bumping)

@paulo-ferraz-oliveira
Copy link
Contributor Author

Hm... GitHub action is broken. Moving to a working container-based approach.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I had to bump CI min. to OTP 21 due to hackney pulling a parse_trans version that requires it. Is this acceptable?

@codecov-io
Copy link

codecov-io commented Mar 23, 2021 •
edited
Loading

Codecov Report

Merging #107 (e35c50b) into main (2f2fafb) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   76.25%   76.32%   +0.07%     
==========================================
  Files          12       12              
  Lines         779      756      -23     
==========================================
- Hits          594      577      -17     
+ Misses        185      179       -6
Impacted Files Coverage Δ
src/elli_http.erl 68.11% <0.00%> (-0.19%) ⬇️
src/elli_tcp.erl 86.66% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2fafb...e35c50b. Read the comment docs.

@tsloughter
Copy link
Member

What about the erlef/setup-elixir action instead of the containers?

@paulo-ferraz-oliveira
Copy link
Contributor Author

What about the erlef/setup-elixir action instead of the containers?

😄 not yet finished for rebar3. But this can wait, sure.

yurrriq
yurrriq reviewed Apr 9, 2021
View reviewed changes
.github/workflows/main.yml Outdated
@@ -15,15 +15,15 @@ jobs:

strategy:
matrix:
otp_version: ['23.1', '22.3.4.2', '21.3.8.16', '20.3.8.21']
otp_version: ['23', '22', '21']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add back R20 now?

Copy link
Contributor Author

@paulo-ferraz-oliveira paulo-ferraz-oliveira Apr 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If hackney's no longer forcing a min. of 21, sure.

Edit: but I guess it still is, via parse_trans: https://github.com/uwiger/parse_trans/blob/master/rebar.config#L18.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add 20?

@paulo-ferraz-oliveira
Copy link
Contributor Author

Any chance this gets merged and tagged any time soon? Thanks.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Now that OTP 24 is out, is it possible to re-run the CI, so I can move toward finalising this? CI (just now) was failing for inexistent Erlang version (setup-beam downloads from Hex.pm). It is possible the version was not there yet.

@tsloughter
Copy link
Member

Not sure how to force it to rerun all the CI. Can you maybe rebase and do a new push? Or create a new PR?

@paulo-ferraz-oliveira
Copy link
Contributor Author

Not sure how to force it to rerun all the CI. Can you maybe rebase and do a new push? Or create a new PR?

Yeah, my recent push recreated the CI, but it's broken elsewhere. Will have to dig in later.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Using 24.0 here eventually lead to a fix in setup-beam: erlef/setup-beam#34.

Will wait for that and then push an update to CI.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #107 (8628263) into main (2f2fafb) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   76.25%   76.32%   +0.07%     
==========================================
  Files          12       12              
  Lines         779      756      -23     
==========================================
- Hits          594      577      -17     
+ Misses        185      179       -6
Impacted Files Coverage Δ
src/elli_http.erl 68.11% <0.00%> (-0.19%) ⬇️
src/elli_tcp.erl 86.66% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2fafb...8628263. Read the comment docs.

@paulo-ferraz-oliveira
Prevent OTP 24 compile-time warning
fdc29f2 
(parse_trans required bumping)
@paulo-ferraz-oliveira
Copy link
Contributor Author

Ready for re-review, now that CI's passing.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Bump.

@tsloughter tsloughter merged commit 3ec3522 into elli-lib:main Jun 17, 2021
@paulo-ferraz-oliveira
Copy link
Contributor Author

Thank you, Tristan.

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/otp24-compile-warning branch July 13, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq left review comments

@tsloughter tsloughter tsloughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulo-ferraz-oliveira @codecov-io @tsloughter @codecov-commenter @yurrriq