Updating my fork with changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixing navigation into cell which has multiple focusable elements * updating changelog * adding table keyboard navigation tests * deleting from master * adding table keyboard navigation tests * deleting files from master, pushed by mistaked * adding packages needed for a11y testing and generate documentation for behavior files * Update packages/a11y-testing/LICENSE Co-authored-by: Elizabeth Craig <[email protected]> * Update packages/a11y-testing/package.json Co-authored-by: Elizabeth Craig <[email protected]> * improving based on review * adressing comment regarding jest package * impoving dependency package Co-authored-by: Milan Turon <[email protected]> Co-authored-by: Elizabeth Craig <[email protected]>
…unction component (#15054) * Moving breadcrumb to react-next * Reverting an accidental file. * Change files * Updating the api * Updating example snapshots.
* changes * undo * Change files * typing updates. * fixing build break.
* Floating Pickers: Move to react-next * update the api file
* Feat: convert card to be design system provider * Change files
* remove un-used prop * impl applyTo * Change files * fixes * merge * resolve comment * update api * call useFocusRects * resolve comment * udpate api
* fix: elementContains should behave like .contains() * Change files
* style fixes * update snapshots * fix split button styles * more fixes * revert flow-grow and fix ghost hover/press background * cleanup * resolve comment * fix ghost disabled background & fluid compound * merge
* Add new package for spinbutton v8 * Adding src folder and empty index file. * add version.ts files * add @uifabric/set-version as a dependency * change to react and add config folder * Add package to CODEOWNERS file and update api-extractor.json * update dependency version * add etc folder Co-authored-by: KHMakoto <[email protected]>
* Migrate ComboBox to react-next * Change files * Migrate ComboBoxOptionWrapper * Add stub function component * Disable tests that fail to compile for now * Hoist default props * Finalize partial migration * Test fixes in progress * Fix most tests * Cleanup tests * Fix more test cases * Change files * Fix build * Revert unintended changes * Revert unintended change * Fix lint error * Address feedback * Update ref types Co-authored-by: Elizabeth Craig <[email protected]>
* Adding compat exports to v7 * Change files * Removing toggle, slider, pivot, link, and checkbox from @fluentui/react compat exports. * Delete Toggle.ts * Delete Slider.ts * Delete Pivot.ts * Delete Checkbox.ts * Delete Link.ts * Reverting an unintended change. * Updating react-next compat index file * Removing react-next's compat exports for toggle, slider, pivot, link, and checkbox
Upload images used in screener and other places to our CDN that we use for the website (http://fabricweb.azureedge.net/fabric-website/*). This will make them load faster than if we uploaded them to normal blob storages, which can be important for getting correct results in screener tests. For testing purposes I have the images uploading as part of the PR build, but before check-in I plan to change it so the images upload **only on master builds** (mainly to avoid accidental changes). This means that if you want to use a new image, you'll have to check it in separately first, but that shouldn't be a big issue since it won't happen very often. Also update other upload tasks to use the new AzureUpload task which gzips things. This should make the PR deploy site load faster.
* Replaced "drop-down menu" with "dropdown" We're deviating from the Microsoft Writing Style Guide guidance (hyphenating drop-down), because compounded (dropdown) style is more commonly seen across other industry-leading design systems. * Added explanation of when to use a dropdown * Removed "list" from "dropdown list" references * Removed erroneous guidance about form fields Somehow guidance got checked in that doesn't map to our best practices. Correcting that, so we ensure everyone standardizes on the uses of asterisks for denoting required fields. And added a reminder note about ARIA properties to remind folks to consider the screenreader experience. * Fix aria-required guidance * Change files * updates Co-authored-by: jennbost <[email protected]>
* Updating release notes for button. * Button release notes * Change files * Update packages/react-next/RELEASE_NOTES.md Co-authored-by: Makoto Morimoto <[email protected]> * Update packages/react-next/RELEASE_NOTES.md Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: Makoto Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)