Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add image generation capability to Telegram messaging #491

Closed

Conversation

0xTomDaniel
Copy link

Relates to:

N/A

Risks

Low. Image generation could be affected

Background

What does this PR do?

  • Completes image generation functionality for Together provider
  • Adds image generation functionality to Telegram

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)
Improvements (misc. changes to existing features)
Features (non-breaking change which adds functionality)

Testing

Where should a reviewer start?

Just follow testing steps below.

Detailed testing steps

  1. (optionally) Add "imageModelProvider": "llama_cloud" to a character file
  2. (optionally) Add a Together API key if using llama_cloud provider. Otherwise ensure there's an API key for the chosen `modelProvider"
  3. Ask the agent on Telegram to generate an image.
  4. Verify that an image is returned as requested.

@0xTomDaniel 0xTomDaniel changed the title Add image provider Add image generation capability to Telegram messaging Nov 22, 2024
.env.example Outdated Show resolved Hide resolved
Copy link
Contributor

@ponderingdemocritus ponderingdemocritus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work - left comments

Please add formatted comments into the plugin-image-generation

claude is your best friend here

@yakul0

This comment was marked as abuse.

@0xTomDaniel
Copy link
Author

@ponderingdemocritus resolved your feedback

@monilpat
Copy link
Collaborator

Great work please resolve the merge conflicts and you are good to go : )

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts

@0xTomDaniel
Copy link
Author

0xTomDaniel commented Nov 29, 2024

@monilpat Resolved everything and then another conflict occurred shortly afterward. Should be good now.

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the latest changes!

@jkbrooks
Copy link
Contributor

@monilpat @0xTomDaniel we failed linting, please resolve

Run pnpm run lint

> eliza@ lint /home/runner/work/eliza/eliza
> bash ./scripts/lint.sh

Linting package: plugin-conflux
No lint script found in plugin-conflux, skipping lint...
Linting package: client-direct
Running lint for package: client-direct

> @ai1[6](https://github.com/ai16z/eliza/actions/runs/12080760175/job/33691672543?pr=491#step:7:7)z/[email protected] lint
> eslint . --fix

Successfully linted client-direct

Linting package: plugin-image-generation
Running lint for package: plugin-image-generation

> @ai16z/[email protected] lint
> eslint . --fix


/home/runner/work/eliza/eliza/packages/plugin-image-generation/src/index.ts
Error:   13:[10](https://github.com/ai16z/eliza/actions/runs/12080760175/job/33691672543?pr=491#step:7:11)  error  'generateCaption' is defined but never used. Allowed unused vars must match /^_/u  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /home/runner/work/eliza/eliza/packages/plugin-image-generation
npm error workspace @ai[16](https://github.com/ai16z/eliza/actions/runs/12080760175/job/33691672543?pr=491#step:7:17)z/[email protected]
npm error location /home/runner/work/eliza/eliza/packages/plugin-image-generation
npm error command failed
npm error command sh -c eslint . --fix
Lint failed for plugin-image-generation
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

@odilitime odilitime changed the base branch from main to develop December 18, 2024 07:52
@odilitime odilitime changed the title Add image generation capability to Telegram messaging feat: Add image generation capability to Telegram messaging Dec 18, 2024
@shakkernerd shakkernerd deleted the branch elizaOS:develop December 22, 2024 07:01
@odilitime odilitime reopened this Dec 22, 2024
@odilitime
Copy link
Collaborator

Closed because of conflict resubmission #1505

@odilitime odilitime closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants