Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: video generation plugin #394

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: video generation plugin #394

merged 2 commits into from
Nov 19, 2024

Conversation

dorianjanezic
Copy link
Contributor

@dorianjanezic dorianjanezic commented Nov 18, 2024

Relates to:
video generation

Risks
Low - Changes are contained within the video generation plugin and don't affect other functionality. Main risk is failed video generation or attachment, which is handled gracefully with error messages.

Background
What does this PR do?
Fixes video generation plugin to properly handle the Luma AI API response and correctly attach generated videos to Discord messages.

What kind of change is this?
Plugin

Why are we doing this? Any context or related work?
adding video gen feature

Documentation changes needed?
Yes, adding LUMA LABS API to env.example

Testing
As a user, send a message to generate a video:
Send "Generate a video of a sunset"
Verify bot responds with "I'll generate a video based on your prompt"
Wait for video generation (about 1-2 minutes)
Verify bot sends back a message with the video attached

videoGenerationPlugin should be added to agent runtime & to package.json

@dorianjanezic
Copy link
Contributor Author

@lalalune hey, all good with this plugin?

@monilpat
Copy link
Collaborator

Thanks for working on this - Please update the PR title :)

@monilpat
Copy link
Collaborator

Can we add a test for this new plugin? As well as a screengrab of successful video generation? Thanks so much!

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Great feature and implementation! Please address the comments then good to go!

@dorianjanezic dorianjanezic changed the title video generation plugin feat: video generation plugin Nov 19, 2024
@dorianjanezic
Copy link
Contributor Author

dorianjanezic commented Nov 19, 2024

hey @monilpat , created constants file and videoGeneration test.

Screenshot 2024-11-18 at 11 58 23

@sirkitree sirkitree merged commit af4e1fd into elizaOS:main Nov 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants