Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix starknet plugin by replacing walletProvider with portfolio provider #2029

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

Jonatan-Chaverri
Copy link
Contributor

Relates to

#2028

Risks

Low risk, just fixing something that use to be broken so that people now can begin to use the starknet plugin.

Background

What does this PR do?

Fixes the starknet plugin by updating some broken references.

What kind of change is this?

Bug fixes

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Detailed testing steps

  • Clone the eliza-starter repo
  • replace the starknet plugin dependency in package.json with "@elizaos/plugin-starknet": "file:./plugin-starknet", where plugin-starknet is the path to the plugin-starknet folder of the plugin that was changed here.
  • cd into the plugin folder, build the plugin with pnpm build
  • install the plugin in eliza-starter with pnpm i
  • add the plugin in your character plugins
  • run the project with pnpm start, it should include the starknet actions and run without issues.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jonatan-Chaverri! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@Jonatan-Chaverri Jonatan-Chaverri changed the base branch from main to develop January 8, 2025 16:42
@Jonatan-Chaverri Jonatan-Chaverri changed the base branch from develop to main January 8, 2025 16:45
@Jonatan-Chaverri Jonatan-Chaverri changed the base branch from main to develop January 8, 2025 16:50
@Jonatan-Chaverri Jonatan-Chaverri force-pushed the fix_starknet_plugin branch 3 times, most recently from a1bc661 to 2128b96 Compare January 8, 2025 20:42
@tcm390
Copy link
Collaborator

tcm390 commented Jan 11, 2025

Hello @Jonatan-Chaverri could you please resolve the conflict

@Jonatan-Chaverri
Copy link
Contributor Author

@tcm390 done

@tcm390 tcm390 merged commit bf5b72d into elizaOS:develop Jan 11, 2025
3 checks passed
@tcm390 tcm390 mentioned this pull request Jan 11, 2025
@Jonatan-Chaverri Jonatan-Chaverri deleted the fix_starknet_plugin branch January 11, 2025 23:57
0xpi-ai pushed a commit to 0xpi-ai/NayariAI that referenced this pull request Jan 15, 2025
…ugin

Fix: fix starknet plugin by replacing walletProvider with portfolio provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants