feat: improve twitter paragraph splitting if containing url #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Risks
Low, improves twitter content splitting if containing url
Background
What does this PR do?
The function
splitParagraphwill split tweet in order for twitter max length. However, url format is not considered so blank(" ") will be added after url "."(which considered as the end of sentence), resulting in bad format.This pull request first convert urls into a 23 character-long placeholder(which is what twitter take url into account), then do the splitting and at last restore the url
What kind of change is this?
Bug fixes as well as improvement
Documentation changes needed?
No
Testing
Where should a reviewer start?
Detailed testing steps