fix: rm unused variable X_SERVER_URL #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low
Background
What does this PR do?
Removes the unused X_SERVER_URL that appears to be a relic of legacy code.
What kind of change is this?
Improvement
Why are we doing this? Any context or related work?
I noticed this doesn't appear to be used in the code anymore. I also noticed that the XAI_API_KEY is only used for loading the Together API but it has it's own API key var now (which can be used to load the provider). Should I go ahead and remove it as well? I feel like most people think these vars are related to X/Twitter or xAI and may be confused by them.
Documentation changes needed?
A lot of the documentation does need to be updated to reflect the changes to selecting providers and models. Many may be trying to use this unworking and unused variable. I removed it from the Readme's on here in this PR though.
Discord username
@proteanx (same as on here)