Merge pull request #535 from 0xFlicker/fix-videoservice-cache

fix: pass runtime to video service
elizaOS · Nov 23, 2024 · b08f3f7 · b08f3f7
2 parents 4e85200 + c64074a
commit b08f3f7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/packages/client-discord/src/attachments.ts b/packages/client-discord/src/attachments.ts
@@ -335,7 +335,10 @@ export class AttachmentManager {
         }
 
         if (videoService.isVideoUrl(attachment.url)) {
-            const videoInfo = await videoService.processVideo(attachment.url);
+            const videoInfo = await videoService.processVideo(
+                attachment.url,
+                this.runtime
+            );
             return {
                 id: attachment.id,
                 url: attachment.url,

diff --git a/packages/client-discord/src/messages.ts b/packages/client-discord/src/messages.ts
@@ -693,15 +693,18 @@ export class MessageManager {
             if (
                 this.runtime
                     .getService<IVideoService>(ServiceType.VIDEO)
-                    .isVideoUrl(url)
+                    ?.isVideoUrl(url)
             ) {
                 const videoService = this.runtime.getService<IVideoService>(
                     ServiceType.VIDEO
                 );
                 if (!videoService) {
                     throw new Error("Video service not found");
                 }
-                const videoInfo = await videoService.processVideo(url);
+                const videoInfo = await videoService.processVideo(
+                    url,
+                    this.runtime
+                );
 
                 attachments.push({
                     id: `youtube-${Date.now()}`,

diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -1033,7 +1033,6 @@ export interface ITranscriptionService extends Service {
 
 export interface IVideoService extends Service {
     isVideoUrl(url: string): boolean;
-    processVideo(url: string): Promise<Media>;
     fetchVideoInfo(url: string): Promise<Media>;
     downloadVideo(videoInfo: Media): Promise<string>;
     processVideo(url: string, runtime: IAgentRuntime): Promise<Media>;

diff --git a/packages/plugin-node/src/services/video.ts b/packages/plugin-node/src/services/video.ts
@@ -93,7 +93,7 @@ export class VideoService extends Service implements IVideoService {
 
     public async processVideo(
         url: string,
-        runtime?: IAgentRuntime
+        runtime: IAgentRuntime
     ): Promise<Media> {
         this.queue.push(url);
         this.processQueue(runtime);