Add tests for wallaby's behavior when starting chromedriver #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some initial test coverage around how wallaby starts the chromedriver executable. I figured I should add some test coverage to protect the existing behavior before making changes to address #509.
Since chromedriver is started on wallaby's application startup, these tests
The benefit of the
FakeChromedriverScript
is we can record the arguments that chromedriver is being started and assert that default and user configured options are passed correctly. It also makes it much simpler to test checks like running against an old version of chromedriver.