Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for wallaby's behavior when starting chromedriver #510

Conversation

aaronrenner
Copy link
Member

This adds some initial test coverage around how wallaby starts the chromedriver executable. I figured I should add some test coverage to protect the existing behavior before making changes to address #509.

Since chromedriver is started on wallaby's application startup, these tests

  1. stop wallaby
  2. make the necessary environment changes (to use fake script and chromedriver as main driver)
  3. starts wallaby

The benefit of the FakeChromedriverScript is we can record the arguments that chromedriver is being started and assert that default and user configured options are passed correctly. It also makes it much simpler to test checks like running against an old version of chromedriver.

@aaronrenner
Copy link
Member Author

I'm realizing I have a little more work to do on these test helpers that generate the fake chromedriver script. I'm going to close this PR and open a new one when I'm done changing things.

@aaronrenner aaronrenner closed this Feb 9, 2020
@aaronrenner aaronrenner reopened this Feb 9, 2020
@aaronrenner aaronrenner force-pushed the ar-pass-additional-options-to-chromedriver-start branch from ba55890 to 75e5f6f Compare February 9, 2020 18:26
@aaronrenner aaronrenner closed this Feb 9, 2020
@aaronrenner aaronrenner deleted the ar-pass-additional-options-to-chromedriver-start branch February 9, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant