Fix typos and improve language #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
requested changes
Aug 19, 2024
Fixed SEARCH/REPLACE block for `lib/tesla/middleware/path_params.ex
Outdated
Show resolved
Hide resolved
yordis
reviewed
Aug 19, 2024
lib/tesla/adapter/mint.ex
Outdated
| @@ -315,7 +315,7 @@ if Code.ensure_loaded?(Mint.HTTP) do | |||
|
|
|||
| {:error, _conn, error, _res} -> | |||
| if opts[:close_conn], do: {:ok, _conn} = close(conn) | |||
| {:error, "Encounter Mint error #{inspect(error)}"} | |||
| {:error, "Encountered Mint error #{inspect(error)}"} | |||
There was a problem hiding this comment.
I am unsure if we should change the error, even when it is a misspelling; I am uncertain who would rely on it ...
There was a problem hiding this comment.
Good thinking, I would fix it sooner than later given probably the number of people relying on pattern matching this error message is probably close to 0.
There was a problem hiding this comment.
There was a problem hiding this comment.
Do you mind adding a TODO comment to change when we decide to break change?
There was a problem hiding this comment.
Very good idea, done that
yordis
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for reviewing.