FollowRedirects middleware: copy opts from response env #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Middlewares that come after FollowRedirects might use `opts` for state they need to keep if they are called multiple times. The specific use case we have that requires this: Our pool for gun requires explicit checkout/checkin of the connection. We have a middleware after FollowRedirects that checks out a connection, passes it to adapter opts, requests and then checks the connection back in. However, if `body_as: :chunks` options is used, we, obviously, can't checkin the connection in the middleware as it needs to be passed to the client after leaving the middleware. But if there was a redirect to a different host we want to checkin the old connection and checkout a new one ourselves. So we want to check if adapter options already have a connection in them and checkin it if present.
rinpatch
force-pushed
the
fix/redirect-middleware-ignores-env
branch
from
3484e0f
to
3a2789d
Compare
github-actions bot
pushed a commit
to kphrx/pleroma
that referenced
this pull request
Sep 5, 2020
Requires a patched Tesla due to upstream not saving opts between redirects, patch submitted at elixir-tesla/tesla#414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middlewares that come after FollowRedirects might use
optsfor statethey need to keep if they are called multiple times.
The specific use case we have that requires this: Our pool for
gun requires explicit checkout/checkin of the connection. We have a
middleware after FollowRedirects that checks out a connection, passes
it to adapter opts, requests and then checks the connection back in.
However, if
body_as: :chunksoptions is used, we, obviously,can't checkin the connection in the middleware as it needs to be passed
to the client after leaving the middleware. But if there was a redirect
to a different host we want to checkin the old connection and checkout
a new one ourselves. So we want to check if adapter options already
have a connection in them and checkin it if present.