Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Logger middleware to configured at runtime #409

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

thiamsantos
Copy link
Contributor

@thiamsantos thiamsantos commented Aug 18, 2020

Motivation

Sometime we have the need to enable/disable the tesla logger debug at runtime, via an environment variable or something similar. Today this configuration is fetched only at compile-time.

Ref #325

Proposed solution

Allow Logger middleware to configured at runtime by merging the compile-time config with the options of the middleware.

@teamon teamon merged commit 35ac934 into elixir-tesla:master Aug 23, 2020
@teamon
Copy link
Member

teamon commented Aug 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants