-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dyalizer errors and warns #393
Merged
teamon
merged 9 commits into
elixir-tesla:master
from
gabrielgiordan:fix-dyalizer-errors-and-warns
Jun 17, 2020
Merged
Fix dyalizer errors and warns #393
teamon
merged 9 commits into
elixir-tesla:master
from
gabrielgiordan:fix-dyalizer-errors-and-warns
Jun 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since @disable_legacy_event is a compile_env equivalent env
response_opts is already a keyword list
response_opts is already a keyword list
The opts parameter is not a map, but a keyword list
:gun.info from master does return :origin_scheme
To handle gun_opts with keys from master :gun branch
To does not complain on gun_opts with keys from master :gun branch
Fix: Function :idna.encode/1 does not exist. Fix: Function :ssl_verify_hostname.verify_fun/3 does not exist.
teamon
reviewed
Jun 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Thank you for looking into that! I left a few comments.
alex-strizhakov
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
teamon
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After struggling with a
Tesla.Mock.json/2
dialyzer warning at my application, I have found that the opts spec is a keyword list inside a list, instead of a plain keyword list.So, I have analyzed other warnings and errors and also fixed those.
Edit: I suppose the CI is expected to fail at
certificates_verification
fortest/tesla/adapter/mint_test.exs:59
, as other PRs also failed at this step, is it right?