Gun adapter #304

alex-strizhakov · 2019-06-19T12:14:48Z

Adapter for gun - https://github.com/ninenines/gun

Added custom option - max_body.

mix.exs

lib/tesla/adapter/gun.ex

+              IO.inspect(msg)
+              IO.inspect("unsupported message received in read response.")
+              msg
+          end


lib/tesla/adapter/gun.ex

+            msg ->
+              IO.inspect(msg)
+              IO.inspect("unsupported message received in read body.")
+              msg


lib/tesla/adapter/gun.ex

+
+            msg ->
+              IO.inspect(msg)
+              IO.inspect("unsupported message received in read response.")


lib/tesla/adapter/gun.ex

+    defp read_response(pid, stream, opts) do
+      receive do
+        msg ->
+          case msg do


lib/tesla/adapter/gun.ex

+
+      receive do
+        msg ->
+          case msg do


codecov · 2019-06-19T16:01:57Z

Codecov Report

Merging #304 into master will decrease coverage by 1.29%.
The diff coverage is 82.69%.

@@            Coverage Diff            @@
##           master     #304     +/-   ##
=========================================
- Coverage   95.43%   94.14%   -1.3%     
=========================================
  Files          23       24      +1     
  Lines         460      512     +52     
=========================================
+ Hits          439      482     +43     
- Misses         21       30      +9

Impacted Files	Coverage Δ
lib/tesla/adapter/gun.ex	`82.69% <82.69%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5436e...6ad53ea. Read the comment docs.

codecov · 2019-06-19T16:01:57Z

Codecov Report

Merging #304 into master will decrease coverage by 0.58%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   95.43%   94.85%   -0.59%     
==========================================
  Files          23       24       +1     
  Lines         460      505      +45     
==========================================
+ Hits          439      479      +40     
- Misses         21       26       +5

Impacted Files	Coverage Δ
lib/tesla/adapter/gun.ex	`93.61% <93.61%> (ø)`
lib/tesla.ex	`83.33% <0%> (-4.17%)`	⬇️
lib/tesla/middleware/decode_rels.ex	`100% <0%> (ø)`	⬆️
lib/tesla/builder.ex	`100% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b5f77...3cb7b37. Read the comment docs.

teamon

NICE! 👏

The only thing I'm not really sure about are the exposed options, I'd rather keep them to the minimum, do not set another custom set of defaults and just refer to gun's documentation instead.

lib/tesla/adapter/gun.ex

mix.exs

test/tesla/adapter/gun_test.exs

rinpatch · 2019-07-12T18:16:01Z

@teamon could you give this another review please?

teamon · 2019-07-13T09:40:46Z

Please rebase to recent master (it includes CI fixes). Once all the tests pass I'd be happy to merge this MR 🚀

added gun_down, gun_error message types

Co-Authored-By: rinpatch <[email protected]>

Co-Authored-By: Tymon Tobolski <[email protected]>

added fallback adapter timeout option error naming standardization

alex-strizhakov · 2019-07-18T09:55:31Z

@teamon can elixir 1.4.5 and otp 18 be removed?

teamon · 2019-07-18T15:24:34Z

I’m currently on holidays, I’ll get back to you next week.

…

On 18 Jul 2019, 12:55 +0300, Alexander Strizhakov ***@***.***>, wrote: @teamon can elixir 1.4.5 and otp 18 be removed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

teamon · 2019-07-22T11:24:39Z

Dropping support for elixir 1.4 & otp 18 would be a breaking change and would require releasing tesla 2.0.

However, if there is no easy way to provide 1.4 support I'm ok with that, 1.4 caused few other issues already and we have elixir 1.19 already.

alex-strizhakov · 2019-07-22T12:33:36Z

How it can be done?
httparrot 1.2.0 requires con_cache 0.13, which can't be compiled on 1.4.5.
cowlib 2.5.0 can be compiled on otp 19+.
I don't see any easy way to fix this.

teamon · 2019-07-22T12:34:57Z

@alex-strizhakov And do we have to bump httparrot? :)

alex-strizhakov · 2019-07-22T12:36:51Z

@teamon without update of httparrot we need to have {:cowlib, "~> 1.0.2", override: true, optional: true} in mix.exs.

teamon · 2019-07-22T12:50:22Z

... and gun requires cowlib.

Ok, let's drop 1.4 & 18 🔥

alex-strizhakov · 2019-07-22T13:01:12Z

... and gun requires cowlib.
Forgot about it 😅

codecov · 2019-07-22T13:03:09Z

Codecov Report

Merging #304 into master will decrease coverage by 0.58%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   95.43%   94.85%   -0.59%     
==========================================
  Files          23       24       +1     
  Lines         460      505      +45     
==========================================
+ Hits          439      479      +40     
- Misses         21       26       +5

Impacted Files	Coverage Δ
lib/tesla/adapter/gun.ex	`93.61% <93.61%> (ø)`
lib/tesla.ex	`83.33% <0%> (-4.17%)`	⬇️
lib/tesla/middleware/decode_rels.ex	`100% <0%> (ø)`	⬆️
lib/tesla/builder.ex	`100% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b5f77...3cb7b37. Read the comment docs.

codecov · 2019-07-22T13:34:31Z

Codecov Report

Merging #304 into master will decrease coverage by 0.24%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   95.43%   95.19%   -0.25%     
==========================================
  Files          23       25       +2     
  Lines         460      520      +60     
==========================================
+ Hits          439      495      +56     
- Misses         21       25       +4

Impacted Files	Coverage Δ
lib/tesla/adapter/gun.ex	`93.61% <93.61%> (ø)`
lib/tesla/middleware/retry.ex	`93.75% <0%> (-6.25%)`	⬇️
lib/tesla/middleware/decode_rels.ex	`100% <0%> (ø)`	⬆️
lib/tesla/builder.ex	`100% <0%> (ø)`	⬆️
lib/tesla/middleware/path_params.ex	`100% <0%> (ø)`
lib/tesla/adapter/hackney.ex	`96.66% <0%> (+0.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b5f77...d3554f1. Read the comment docs.

rinpatch suggested changes Jun 19, 2019

View reviewed changes

rinpatch reviewed Jun 19, 2019

View reviewed changes

lib/tesla/adapter/gun.ex Outdated

receive do

msg ->

case msg do

This comment was marked as resolved.

Sign in to view

rinpatch approved these changes Jun 20, 2019

View reviewed changes

teamon added the feature ✨ label Jun 24, 2019

teamon requested changes Jun 24, 2019

View reviewed changes

lib/tesla/adapter/gun.ex Outdated Show resolved Hide resolved

lib/tesla/adapter/gun.ex Outdated Show resolved Hide resolved

lib/tesla/adapter/gun.ex Outdated Show resolved Hide resolved

mix.exs Outdated Show resolved Hide resolved

test/tesla/adapter/gun_test.exs Show resolved Hide resolved

alex-strizhakov and others added 10 commits July 14, 2019 08:42

gun adapter

e1f33e8

removing unnecessary msg case

fd95588

added gun_down, gun_error message types

Update mix.exs

fe6294b

Co-Authored-By: rinpatch <[email protected]>

removing unnecessary monitor

607d0a2

fixing test coverage

ce00e32

Update lib/tesla/adapter/gun.ex

74f4b45

Co-Authored-By: Tymon Tobolski <[email protected]>

Update lib/tesla/adapter/gun.ex

4612a6c

Co-Authored-By: Tymon Tobolski <[email protected]>

removed default gun adapter options

8c03026

added fallback adapter timeout option error naming standardization

removing confusing options

0971a92

updating httparrot

b50b7f4

teamon mentioned this pull request Jul 22, 2019

Support gun as backend/adapter #285

Closed

dropping elixir 1.4.5 and OTP 18

3cb7b37

using httparror for streaming

d3554f1

teamon merged commit 9795075 into elixir-tesla:master Jul 22, 2019

alex-strizhakov deleted the gun-adapter branch July 22, 2019 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gun adapter #304

Gun adapter #304

alex-strizhakov commented Jun 19, 2019

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

codecov bot commented Jun 19, 2019

codecov bot commented Jun 19, 2019 •

edited

Loading

teamon left a comment

rinpatch commented Jul 12, 2019

teamon commented Jul 13, 2019

alex-strizhakov commented Jul 18, 2019

teamon commented Jul 18, 2019 via email

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019 •

edited

Loading

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019 •

edited

Loading

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019

codecov bot commented Jul 22, 2019

codecov bot commented Jul 22, 2019 •

edited

Loading

Gun adapter #304

Gun adapter #304

Conversation

alex-strizhakov commented Jun 19, 2019

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

codecov bot commented Jun 19, 2019

Codecov Report

codecov bot commented Jun 19, 2019 • edited Loading

Codecov Report

teamon left a comment

Choose a reason for hiding this comment

rinpatch commented Jul 12, 2019

teamon commented Jul 13, 2019

alex-strizhakov commented Jul 18, 2019

teamon commented Jul 18, 2019 via email

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019 • edited Loading

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019 • edited Loading

teamon commented Jul 22, 2019

alex-strizhakov commented Jul 22, 2019

codecov bot commented Jul 22, 2019

Codecov Report

codecov bot commented Jul 22, 2019 • edited Loading

Codecov Report

codecov bot commented Jun 19, 2019 •

edited

Loading

alex-strizhakov commented Jul 22, 2019 •

edited

Loading

alex-strizhakov commented Jul 22, 2019 •

edited

Loading

codecov bot commented Jul 22, 2019 •

edited

Loading