Allow to specify a port from the conn #1187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋🏾
Currently the port can be specified by an URI like http://localhost:4200 but in phoenix it's required to do a:
Because we do an
URI.parse/1
here https://github.com/elixir-plug/plug/blob/main/lib/plug/adapters/test/conn.ex#L9Instead the
port
in theconn
struct could be change and that should be cleaner rather than specifing a full URI, in phoenix tests.Thanks for creating Plug!!
PS: Hope that this PR makes sense 😉