Improve perf and docs for Plug.RequestId #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
commented
Oct 13, 2023
| [val | _] -> if valid_request_id?(val), do: {conn, val}, else: {conn, generate_request_id()} | ||
| end | ||
| end | ||
| request_id = get_request_id(conn, header) |
There was a problem hiding this comment.
We don't need to pass in the conn to get_request_id/2 and return it, because we don't update it. One less tuple allocation and one less function call.
Comment on lines
+25
to
+28
| > #### Programmatic access to the request ID {: .tip} | ||
| > | ||
| > To access the request ID programmatically, use the `:assign_as` option (see below) | ||
| > to assign the request ID to a key in `conn.assigns`, and then fetch it from there. |
There was a problem hiding this comment.
Do I love me some admonition blocks
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a plug that gets called A LOT in most applications, so if we can do something more efficiently I believe we should 🙃