highlight calls to erlang modules as modules #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
Kinda late to the party, but I agree with this. I'd have handled the transformation exactly the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 hiya!
Following up on elixir-lang/tree-sitter-elixir#5 (comment):
This PR adds a post-processing step that transforms regular atoms to be modules (
:name_classes) when they're part on the left-hand-side of a.operator, so a call of a function on an erlang module highlights the same as a call on an Elixir module.I'm pretty new to the makeup_elixir codebase so this might not be the correct place to put this transformation. Let me know!
cc: @jonatanklosko