Add support for nominal types #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for `-nominal` to be used in the same way as `-type`. Without this change, OTP's CI can't build documentation for nominal types.
|
💚 💙 💜 💛 ❤️ |
|
Sorry I wasn't able to see the test results after I opened the PR. Now I see the tests failures. I'll investigate and fix them. Maybe it's better to revert this PR? |
|
It was my bad, I was too quick on merging. We just need to tag the tests, I will push a fix soon :) |
|
Pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
-nominalto be used in the same way as-typein documentation. Without this change, OTP's CI can't build documentation for nominal types.Related PR in OTP: PR-9079.