-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Erlang's logger as main logging implementation #9333
Conversation
@josevalim also I believe that the
|
Sounds good, but not in this PR please :) we can do it before or after! |
I am leaving comments in all places that need deprecations and/or changes in future. Only "new features" are:
|
Questions needed resolving:
|
Agreed.
Agreed.
Agreed. I am not sure if it will ever be removed, it would be a major backwards incompatible change and we don't want to use major versions as an excuse to break user code. Plus, Elixir's handler is still a convenient way of having safe built-in handler with overload protection. AFAIK, Erlang doesn't expose its mechanisms for overload protection.
No because of the above. AFAIK Erlang doesn't expose the building blocks for building olp config, so I don't want to be tied to an API we have no control and that we can't rely on. |
I have removed all usage of Improvements to be made:
|
db3036b
to
8b1ef08
Compare
5f5253c
to
173a250
Compare
89ca12d
to
bee248e
Compare
This reduces amount of needed work in most common cases (at least in Elixir) where message is already a string and do not need any formatting
f783957
to
bbe71d8
Compare
Thank you so much @hauleth for the amazing work! ❤️ 💚 💙 💛 💜 |
❤️ 💚 💙 💛 💜 |
This implements Elixir's
Logger
module on top of Erlang'slogger
while providing compatibility layer.logger:log/2-3
to dispatch log messagesuse Erlang formatter for formatting messages instead of handler