Make IO.ANSI.Docs readable on white background #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `default_options` for `IO.ANSI.Docs` uses bright yellow for documentation headers and titles. This is very nice and readable when using a terminal with a dark background. However, when using a terminal with a bright (e.g. white) background, those parts are unfortunately illegible. This patch removes the `:bright` part from the `default_options`, to make the defaults better suited to more people.
josevalim
added a commit
that referenced
this pull request
Nov 7, 2014
Make IO.ANSI.Docs readable on white background
josevalim
added a commit
that referenced
this pull request
Nov 13, 2014
Make IO.ANSI.Docs readable on white background Signed-off-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_optionsforIO.ANSI.Docsuses bright yellow fordocumentation headers and titles.
This is very nice and readable when using a terminal with a dark
background. However, when using a terminal with a bright (e.g. white)
background, those parts are unfortunately illegible.
This patch removes the
:brightpart from thedefault_options, tomake the defaults better suited to those of us who uses white terminals.
I have seen the issues and thread about adding an
.iexfile for havinglocal settings, and I think that's a great idea, but I still think that having
defaults that work for a wider group of developers is a good idea.
Below is a couple of screenshots on the before and after.