-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document generated GRPC.Stub function arguments #341
Draft
davydog187
wants to merge
2
commits into
elixir-grpc:master
Choose a base branch
from
davydog187:document-stub
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−19
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,44 @@ defmodule GRPC.Stub do | |
then use `recv/1` to receive the reply. And if the reply is streaming, `recv/1` | ||
returns a `Stream`. | ||
|
||
You can refer to `call/6` for doc of your RPC functions. | ||
## RPC Functions | ||
|
||
RPC functions generated via the GRPC.Service.rpc/3 macro are exposed in `GRPC.Stub` | ||
module exposing that service. The following function types are generated: | ||
|
||
### Unary | ||
|
||
Unary RPCs are where the client sends a single request, and receives a single response, like a normal | ||
function call. Unary functions take following shape | ||
|
||
case Greeter.Stub.say_hello(channel, %Request{}, opts) do | ||
{:ok, %Response{}} -> | ||
# Received a response | ||
{:ok, headers_map} -> | ||
# Re | ||
end | ||
|
||
See the [Options](#Options) section below for available options | ||
|
||
|
||
|
||
# # The actual function invoked when invoking an RPC function. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will be removing this, just using as a reference for now |
||
# | ||
# Returns | ||
# | ||
# * Unary calls. `{:ok, reply} | {:ok, headers_map} | {:error, error}` | ||
# * Client streaming. A `GRPC.Client.Stream` | ||
# * Server streaming. `{:ok, Enumerable.t} | {:ok, Enumerable.t, trailers_map} | {:error, error}` | ||
# | ||
# Options | ||
# | ||
# * `:timeout` - request timeout. Default is 10s for unary calls and `:infinity` for | ||
# client or server streaming calls | ||
# * `:deadline` - when the request is timeout, will override timeout | ||
# * `:metadata` - a map, your custom metadata | ||
# * `:return_headers` - default is false. When it's true, a three elem tuple will be returned | ||
# with the last elem being a map of headers `%{headers: headers, trailers: trailers}`(unary) or | ||
# `%{headers: headers}`(server streaming) | ||
""" | ||
alias GRPC.Channel | ||
@insecure_scheme "http" | ||
|
@@ -113,7 +150,7 @@ defmodule GRPC.Stub do | |
iex> GRPC.Stub.connect("localhost:50051", accepted_compressors: [GRPC.Compressor.Gzip]) | ||
{:ok, channel} | ||
|
||
iex> GRPC.Stub.connect("/paht/to/unix.sock") | ||
iex> GRPC.Stub.connect("/path/to/unix.sock") | ||
{:ok, channel} | ||
|
||
## Options | ||
|
@@ -219,23 +256,6 @@ defmodule GRPC.Stub do | |
end | ||
|
||
@doc false | ||
# # The actual function invoked when invoking an RPC function. | ||
# | ||
# Returns | ||
# | ||
# * Unary calls. `{:ok, reply} | {:ok, headers_map} | {:error, error}` | ||
# * Client streaming. A `GRPC.Client.Stream` | ||
# * Server streaming. `{:ok, Enumerable.t} | {:ok, Enumerable.t, trailers_map} | {:error, error}` | ||
# | ||
# Options | ||
# | ||
# * `:timeout` - request timeout. Default is 10s for unary calls and `:infinity` for | ||
# client or server streaming calls | ||
# * `:deadline` - when the request is timeout, will override timeout | ||
# * `:metadata` - a map, your custom metadata | ||
# * `:return_headers` - default is false. When it's true, a three elem tuple will be returned | ||
# with the last elem being a map of headers `%{headers: headers, trailers: trailers}`(unary) or | ||
# `%{headers: headers}`(server streaming) | ||
def call(_service_mod, rpc, %{channel: channel} = stream, request, opts) do | ||
{_, {req_mod, req_stream}, {res_mod, response_stream}} = rpc | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct