Add client request to telemetry metadata #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
approved these changes
Jul 6, 2023
ssepml
force-pushed
the
telemetry_add_req
branch
2 times, most recently
from
5eca7e3
to
d197e81
Compare
|
@polvalente I added some asserts as you suggested. Though I only asserted some of the fields, specially for the stream. If you have something specific in mind, I can add it. |
ssepml
force-pushed
the
telemetry_add_req
branch
from
d197e81
to
e448ce1
Compare
|
Just checking up, is there anything else I can do to move this forward? |
ssepml
force-pushed
the
telemetry_add_req
branch
from
e448ce1
to
403752b
Compare
|
Hi, any chance to get a second look at this? It would be great to have this included. |
sleipnir
approved these changes
Sep 12, 2023
|
Hi @polvalente @sleipnir , thanks for the approvals! Just for my information, is there anything else that needs to happen before this gets merged? |
|
ping @polvalente |
|
This is on my to-do list :) |
|
@polvalente I apologize if I'm being pushy, but are there any news on this? |
polvalente
approved these changes
Nov 27, 2023
polvalente
force-pushed
the
telemetry_add_req
branch
from
403752b
to
556f666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having the actual client request in the telemetry event can be useful to cover more use cases, e.g. if you want to log specifics of the requests you are doing.
NOTE: Not sure if this was considered and discarded already so I just went ahead and created the PR as this would be helpful for my use case.