Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ranch_tcp opts: ip, ipv6_v6only, inet, inet6 #308

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Add support for ranch_tcp opts: ip, ipv6_v6only, inet, inet6 #308

merged 6 commits into from
Mar 14, 2023

Conversation

Nezteb
Copy link
Contributor

@Nezteb Nezteb commented Mar 13, 2023

Addresses #305

It's a bit awkward because ranch_tcp's listen options are all keyword tuples except for :inet and :inet6, so I borrowed plug_cowboy's method of passing the network atoms: https://github.com/elixir-plug/plug_cowboy/blob/v2.6.0/lib/plug/cowboy.ex#L360-L361

@polvalente
Copy link
Contributor

Please run the formatter so we can merge :)

@Nezteb
Copy link
Contributor Author

Nezteb commented Mar 14, 2023

Screenshot 2023-03-14 at 12 50 54 AM

@polvalente That's odd, the formatter passes on my machine. 😅

@polvalente
Copy link
Contributor

Screenshot 2023-03-14 at 12 50 54 AM @polvalente That's odd, the formatter passes on my machine. 😅

I think you need to run with Elixir 1.14 (the same as CI)

@Nezteb
Copy link
Contributor Author

Nezteb commented Mar 14, 2023

I think you need to run with Elixir 1.14 (the same as CI)

Oh, the .tool-versions file specified 1.13 so that's what my asdf install was using. 😄

EDIT: Okay format is fixed; I also bumped the Elixir versions for asdf and the Mix project to match what CI is using.

mix.exs Outdated Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
@polvalente polvalente merged commit 321fb7f into elixir-grpc:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants