-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ranch_tcp opts: ip, ipv6_v6only, inet, inet6 #308
Merged
+59
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
reviewed
Mar 14, 2023
polvalente
reviewed
Mar 14, 2023
Please run the formatter so we can merge :) |
@polvalente That's odd, the formatter passes on my machine. 😅 |
@polvalente That's odd, the formatter passes on my machine. 😅 I think you need to run with Elixir 1.14 (the same as CI) |
Oh, the EDIT: Okay format is fixed; I also bumped the Elixir versions for |
polvalente
reviewed
Mar 14, 2023
polvalente
reviewed
Mar 14, 2023
polvalente
reviewed
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #305
It's a bit awkward because
ranch_tcp
's listen options are all keyword tuples except for:inet
and:inet6
, so I borrowedplug_cowboy
's method of passing the network atoms: https://github.com/elixir-plug/plug_cowboy/blob/v2.6.0/lib/plug/cowboy.ex#L360-L361