fix: add @impl to logger interceptor callback #231

wingyplus · 2022-07-19T08:23:51Z

No description provided.

* Use `[]` to get level from `opts` in `init/1`. * Use `Keyword.fetch!/2` to ensure `opts` always has `:level`.

lib/grpc/logger/client.ex

lib/grpc/logger/server.ex

wingyplus added 2 commits July 19, 2022 15:22

fix: add @impl to logger interceptor callback

f0c9482

refactor: make fetch opts in logger interceptor consistency

a88bea6

* Use `[]` to get level from `opts` in `init/1`. * Use `Keyword.fetch!/2` to ensure `opts` always has `:level`.

polvalente reviewed Jul 19, 2022

View reviewed changes

lib/grpc/logger/client.ex Outdated Show resolved Hide resolved

Update lib/grpc/logger/client.ex

a981650

polvalente reviewed Jul 19, 2022

View reviewed changes

lib/grpc/logger/server.ex Outdated Show resolved Hide resolved

polvalente added 3 commits July 19, 2022 10:51

Update lib/grpc/logger/server.ex

463a118

Merge branch 'master' into behaviour-impl

d0cc37e

Merge branch 'master' into behaviour-impl

1e9d85b

polvalente merged commit 65cab5c into elixir-grpc:master Jul 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add @impl to logger interceptor callback #231

fix: add @impl to logger interceptor callback #231

wingyplus commented Jul 19, 2022

fix: add @impl to logger interceptor callback #231

fix: add @impl to logger interceptor callback #231

Conversation

wingyplus commented Jul 19, 2022