Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for request_id in GRPC.Server.Stream #198

Merged
merged 8 commits into from
Jul 17, 2022
Merged

Add support for request_id in GRPC.Server.Stream #198

merged 8 commits into from
Jul 17, 2022

Conversation

ilyashuma
Copy link
Contributor

The small change adds a new field request_id to the GRPC.Server.Stream struct. It may be handy for logging purposes.

polvalente
polvalente reviewed Jul 17, 2022
View reviewed changes
lib/grpc/logger.ex Outdated Show resolved Hide resolved
polvalente
polvalente reviewed Jul 17, 2022
View reviewed changes
lib/grpc/server.ex Outdated Show resolved Hide resolved
@polvalente
Copy link
Contributor

@ilyashuma let me know if you want me to take over these changes

@ilyashuma
Copy link
Contributor Author

Hi, @polvalente, yup, go ahead. Thank you!

@polvalente polvalente mentioned this pull request Jul 17, 2022
Closed
@polvalente polvalente merged commit d1b9dd7 into elixir-grpc:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilyashuma @polvalente