Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't crash on errors from the adapter #175

Merged
merged 3 commits into from
Jul 16, 2022

Conversation

frekw
Copy link
Contributor

@frekw frekw commented Sep 21, 2020

This fixes errors such as:

    Process #PID<0.32571.2> terminating
** (CaseClauseError) no case clause matching: {:error, %GRPC.RPCError{message: ":stream_error: {:stream_error, :cancel, :\"Stream reset by server.\"}", status: 13}}
    (grpc 0.5.0-beta.1) lib/grpc/stub.ex:462: GRPC.Stub.recv_body/5
    (grpc 0.5.0-beta.1) lib/grpc/stub.ex:433: GRPC.Stub.do_recv/2

which I've been seeing.

@ryanwinchester
Copy link

Fixes #188?

@polvalente
Copy link
Contributor

@ryanwinchester looks like this does fix the issue you pointed. I'll mark that as closed upon merge

@polvalente polvalente merged commit 73ab681 into elixir-grpc:master Jul 16, 2022
@frekw frekw deleted the fix/handle-rpc-errors-in-recv branch July 17, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants