shut down gun process when it is not used anymore #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziepaquette
pushed a commit
to brexhq/grpc-elixir
that referenced
this pull request
Feb 11, 2021
Co-authored-by: Tony Han <[email protected]>
lizziepaquette
added a commit
to brexhq/grpc-elixir
that referenced
this pull request
Feb 12, 2021
) Co-authored-by: Tony Han <[email protected]> Co-authored-by: Roy Bao <[email protected]> Co-authored-by: Tony Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now :gun process is not returned to the caller and also not getting shutdown when connection errors, this leads to orphan process and potential memory leak. The gun process will also keep attempting to reconnect but even it if it did reconnect there is no way to actually use it.
This PR shutdown the process when it is not used.