Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Unterminated coveralls ignores #185

Closed
3 tasks
tonyvanriet opened this issue Oct 1, 2019 · 1 comment · Fixed by #186
Closed
3 tasks

Unterminated coveralls ignores #185

tonyvanriet opened this issue Oct 1, 2019 · 1 comment · Fixed by #186

Comments

@tonyvanriet
Copy link

tonyvanriet commented Oct 1, 2019

  • Add label: "TO DO"
  • Add label: "good first issue" or "help wanted" if appropriate
  • Add link to this issue in a comment near the TO DO comment

Describe What Is Incomplete
I noticed that you've used the coveralls line-level ignore in a few places, but it's being terminated with # coveralls-ignore-end instead of # coveralls-ignore-stop.
We noticed ourselves doing this exact same thing accidentally, and as a result, coveralls was ignoring the rest of the file completely rather than turning off the ignore at the desired point.
parroty/excoveralls#197

I intended to search our codebase to make sure we got them all. I searched all of github instead, and happened upon the two examples in xgit. Thought I'd let you know. :)
https://github.com/elixir-git/xgit/search?q=coveralls-ignore-end&unscoped_q=coveralls-ignore-end

Definition of Done
All uses of # coveralls-ignore-start have an associated # coveralls-ignore-stop.

scouten added a commit that referenced this issue Oct 2, 2019
Closes #185. Thank you, @tonyvanriet, for pointing this out! 💜
@scouten
Copy link
Collaborator

scouten commented Oct 2, 2019

Nice catch. Thank you!

scouten added a commit that referenced this issue Oct 2, 2019
Closes #185. Thank you, @tonyvanriet, for pointing this out! 💜
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants