Deprecate "use Gettext" for backends and improve docs #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build fdfdf385cf0d6725a34780329e1a04d426f55c27-PR-392Details
💛 - Coveralls |
josevalim
reviewed
Aug 18, 2024
josevalim
reviewed
Aug 18, 2024
|
@josevalim done with the |
josevalim
reviewed
Aug 19, 2024
| @@ -99,12 +97,12 @@ defmodule Gettext.Compiler do | |||
| end) | |||
| end | |||
|
|
|||
| defp macros() do | |||
| def generate_macros(_env) do | |||
There was a problem hiding this comment.
I would say you can move this to a private function in Gettext. But it can also be done later.
There was a problem hiding this comment.
Yeah anyway it's going away so wherever it lives it won't live there for long hihi
josevalim
reviewed
Aug 19, 2024
| Same as `pngettext_noop/3`, but takes an explicit backend. | ||
| """ | ||
| defmacro pngettext_noop_with_backend(backend, msgctxt, msgid, msgid_plural) do | ||
| backend = Gettext.Compiler.expand_backend(backend, __CALLER__) |
There was a problem hiding this comment.
Honestly, I would not try to share this code, and instead have two implementations of expand_backend, one for macros and another for the compiler. Especially because we want to remove the one in compiler anyway.
josevalim
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.