-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to strip metadata when parsing PO files #141
Conversation
Pull Request Test Coverage Report for Build ff379f76a243351fcb49ffa3076f519e522cc105-PR-141Details
💛 - Coveralls |
@maennchen so what would be a use case where meta information is not needed? Runtime translations? I thought we were still discussing if that's something we want. |
@whatyouhide We need all meta information when we're extracting translations to merge correctly. However when we compile the backend, we don't need any comments etc. I should choose a better name than |
@maennchen something like "strip meta" maybe? IIRC that's what we use in the various Elixir compiler stuff. |
a3b2977
to
9961bb9
Compare
@whatyouhide Changed to |
9961bb9
to
38f7236
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments but this looks great.
da5d93b
to
ff379f7
Compare
@whatyouhide Are we good to merge? |
Fantastic @maennchen 💟 |
Intended to be used in
Gettext.Backend
to speed up compiler and minimize memory usage when meta information is not needed.Uses roughly a third of memory and is two times faster than including all meta information.
Performance Test
Results: