Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geolix does'nt work with elixir 1.9 release #24

Closed
sunboshan opened this issue Jun 25, 2019 · 2 comments
Closed

geolix does'nt work with elixir 1.9 release #24

sunboshan opened this issue Jun 25, 2019 · 2 comments

Comments

@sunboshan
Copy link

In elixir 1.9, it added mix release task to build a release without using distillery.

However it doesn't work with geolix lib, since in the mix.exs,

  def application do
    [
      applications: [:logger, :poolboy],
      included_applications: [:mmdb2_decoder],
      mod: {Geolix, []}
    ]
  end

The included_application part will make mix release complain.

➜ MIX_ENV=prod mix release
===> Compiling poolboy
==> mmdb2_decoder
Compiling 5 files (.ex)
Generated mmdb2_decoder app
==> geolix
Compiling 38 files (.ex)
Generated geolix app
==> a
Compiling 1 file (.ex)
Generated a app
Release a-0.1.0 already exists. Overwrite? [Yn]
* assembling a-0.1.0 on MIX_ENV=prod
* skipping runtime configuration (config/releases.exs not found)
** (Mix) Undefined applications: [mmdb2_decoder]

The solution is to move the mmdb2_decoder to applications would work.

  def application do
    [
      applications: [:logger, :poolboy, :mmdb2_decoder],
      included_applications: [],
      mod: {Geolix, []}
    ]
  end
@mneudert
Copy link
Member

mneudert commented Jul 3, 2019

Sorry for the late reply!

As your issue for Elixir itself has been classified as a real bug (as far as I can see it should have even received a fix by now?) it might be best to slightly circumvent this problem for now.

With a new application it looked like adding :mmdb2_decoder to either :extra_applications or :applications in your own mix.exs seems to build a working release. Once Elixir has received a 1.9.1 release it should work as expected 🤔

@mneudert
Copy link
Member

The recently released Elixir 1.9.1 seems to completely fix this problem ❤️ 💚 💙 💛 💜

mneudert added a commit to elixir-geolix/adapter_mmdb2 that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants